Optimize the parameters for settings.#837
Open
TanShun wants to merge 1 commit intoinfinilabs:masterfrom
Open
Conversation
Member
|
通过环境变量来覆盖插件配置的方式挺好的,不过需要保证之前的方式也是可以的,新增的配置方式需要兼容之前的场景。 |
Author
|
我只是重写了配置方式,没有对参数做处理,原有配置项的作用完全一样,只是把配置文件由IKAnalyzer.cfg.xml改成了IKAnalyzer.yml。因我发现ES提供了一个 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
把插件的私有XML配置改为ES插件支持的标准YAML格式,并把插件私有的配置参数做成ES插件的标准配置参数,这样可以在启动ES的时候通过传递相应的环境变量实现参数的配置,而不用修改插件的配置文件了。在使用Docker搭建ES服务的时候,可以把本插件集成到ES官方镜像中,做成一个新的公共镜像,在创建容器时通过简单的传递环境变量就可以实现热更新字典等相关参数的配置了。