fix: webhook event phase #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silenceqi
approved these changes
Dec 19, 2025
There was a problem hiding this comment.
Pull request overview
This PR changes the StatusFailure constant value from "failure" to "failed" in the webhook event recorder, likely to align with external webhook receiver expectations or Kubernetes naming conventions.
- Changed
StatusFailureconstant value from "failure" to "failed"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| StatusSuccess = "success" | ||
| // StatusFailure indicates that an operation or step failed. | ||
| StatusFailure = "failure" | ||
| StatusFailure = "failed" |
There was a problem hiding this comment.
The constant value has been changed from "failure" to "failed", but the corresponding test in pkg/webrecorder/recorder_test.go at line 251 still expects the old value "failure". This will cause the test TestWebhookEventConstants to fail. The test's expected value needs to be updated to "failed" to match this change.
Suggested change
| StatusFailure = "failed" | |
| StatusFailure = "failure" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.