-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XSite Repl test environment is configured and new tests are added. #360
Conversation
68f04ab
to
0472967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, it would be beneficial to incorporate the xsite.cy.js
test for thorough testing of this PR within the GitHub Actions workflow.
"cy:e2e": "cypress open" | ||
"cy:run": "cypress run --headless --spec 'cypress/e2e/!(xsite.cy.js)'", | ||
"cy:e2e": "cypress open", | ||
"cy:run-xsite": "cypress run --headless --spec 'cypress/e2e/xsite.cy.js'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server ./run-xsite.tests.sh
stop after running, how can we then utilize this command?
OK. I think I will change the whole test running scripts to work over docker and include also xsite tests in it. It will include run-server-for-e2e.sh as well as the pull request verification script. |
@andyuk1986 which is the status here ? |
@karesti I am updating the PR to include the xsite tests in PR checkups too, as well as to use the latest infinispan-dev-mode.xml in one general script. |
@andyuk1986 which is the status here 🙏🏻 ? |
Hey @karesti , at the moment this PR is on hold. I have some work in progress on my local, but there are other priorities now. As soon as I have some time, I will finish the work and will update this PR. |
@andyuk1986 we really need these tests to assure non regression on backups |
Hey Katia, I have started to work on it. Will be ready as soon as possible. |
@andyuk1986 thanks !!! :)) |
Closes #531