Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSite Repl test environment is configured and new tests are added. #360

Closed
wants to merge 1 commit into from

Conversation

andyuk1986
Copy link
Collaborator

@andyuk1986 andyuk1986 commented May 21, 2023

Closes #531

@dpanshug dpanshug self-requested a review May 29, 2023 07:50
Copy link
Collaborator

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, it would be beneficial to incorporate the xsite.cy.js test for thorough testing of this PR within the GitHub Actions workflow.

"cy:e2e": "cypress open"
"cy:run": "cypress run --headless --spec 'cypress/e2e/!(xsite.cy.js)'",
"cy:e2e": "cypress open",
"cy:run-xsite": "cypress run --headless --spec 'cypress/e2e/xsite.cy.js'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server ./run-xsite.tests.sh stop after running, how can we then utilize this command?

@andyuk1986
Copy link
Collaborator Author

OK. I think I will change the whole test running scripts to work over docker and include also xsite tests in it. It will include run-server-for-e2e.sh as well as the pull request verification script.

@karesti
Copy link
Collaborator

karesti commented Jul 3, 2023

@andyuk1986 which is the status here ?

@andyuk1986
Copy link
Collaborator Author

@karesti I am updating the PR to include the xsite tests in PR checkups too, as well as to use the latest infinispan-dev-mode.xml in one general script.

@karesti
Copy link
Collaborator

karesti commented Sep 21, 2023

@andyuk1986 which is the status here 🙏🏻 ?

@andyuk1986
Copy link
Collaborator Author

Hey @karesti , at the moment this PR is on hold. I have some work in progress on my local, but there are other priorities now. As soon as I have some time, I will finish the work and will update this PR.

@karesti
Copy link
Collaborator

karesti commented Oct 16, 2024

@andyuk1986 we really need these tests to assure non regression on backups

@andyuk1986
Copy link
Collaborator Author

Hey Katia, I have started to work on it. Will be ready as soon as possible.

@karesti
Copy link
Collaborator

karesti commented Oct 21, 2024

@andyuk1986 thanks !!! :))

@andyuk1986
Copy link
Collaborator Author

@karesti I am closing this PR as it is really hard to resolve the conflicts after a year pause and changes from main. I have created new PR #540 which includes these changes on the clear rebased main.

@andyuk1986 andyuk1986 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide x-site cypress feature tests
3 participants