[#603] Fixes precision lost with very big numbers #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
force-pushed
the
fix-precision-lost-display
branch
from
017c9c4 to
75962fe
Compare
andyuk1986
force-pushed
the
fix-precision-lost-display
branch
from
75962fe to
e67c087
Compare
Collaborator
|
The PR looks good to me and the issue is fixed. I have updated one of the tests to use int64 type to verify the issue. As soon as the tests workflow is finished, I can merge the PR. |
andyuk1986
approved these changes
Aug 15, 2025
Collaborator
andyuk1986
left a comment
andyuk1986
left a comment
There was a problem hiding this comment.
Will merge as soon as Test workflow is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603
@andyuk1986 might be necessary to add an extra IT test here, any thoughts ?