Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed Banner #242

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Closed Banner #242

merged 2 commits into from
Jul 8, 2024

Conversation

mazenchami
Copy link
Collaborator

@mazenchami mazenchami commented Jul 4, 2024 •
edited
Loading

Description

Adding a closed banner so that we don't have people downloading the app thinking we have the conference going on this year, 2024.

Graphics

iOS Android
ios_screenshot_1
ios_screenshot_2
ios_screenshot_3		 android_screenshot_1
android_screenshot_2
android_screenshot_3

Checklist:

  • I have done a thorough self-review of my code
  • I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • I have run tests and linter

@mazenchami mazenchami requested a review from jamonholmgren July 4, 2024 02:35
@mazenchami mazenchami self-assigned this Jul 4, 2024
@mazenchami mazenchami marked this pull request as ready for review July 4, 2024 02:37
jamonholmgren
jamonholmgren approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@mazenchami mazenchami merged commit cb1c2b9 into main Jul 8, 2024
1 check passed
@mazenchami mazenchami deleted the closed-banner branch July 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees

@mazenchami mazenchami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazenchami @jamonholmgren