Conversation
KCeh
reviewed
Mar 11, 2026
Collaborator
KCeh
left a comment
KCeh
left a comment
There was a problem hiding this comment.
I personally wouldn't enforce transitive dependencies.
We can remove plugins (CPD) that are causing us issue. And I would upgrade everything else that is possible (ex, AGP).
If there are still some issues afterwards, we can dismiss them manully.
KCeh
reviewed
Mar 11, 2026
gradle/libs.versions.toml
Outdated
Comment on lines
+11
to
+21
| commons-lang3 = "3.20.0" | ||
| dokka = "2.1.0" | ||
| jose4j = "0.9.6" | ||
| commons-compress = "1.26.0" | ||
| junit = "4.13.2" | ||
| mockk = "1.14.9" | ||
| json = "20251224" | ||
| netty = "4.1.129.Final" | ||
| protobuf-kotlin = "3.25.5" | ||
| jdom2 = "2.0.6.1" | ||
| rhino = "1.9.1" |
Collaborator
There was a problem hiding this comment.
Can you remove transitive dependencies?
build.gradle
Outdated
Comment on lines
+18
to
+40
| configurations.classpath { | ||
| resolutionStrategy.eachDependency { | ||
| if (requested.group == "io.netty" && requested.name == "netty-handler") { | ||
| useVersion(libs.versions.netty.get()) | ||
| } | ||
| if (requested.group == "com.google.protobuf" && requested.name == "protobuf-kotlin") { | ||
| useVersion(libs.versions.protobuf.kotlin.get()) | ||
| } | ||
| if (requested.group == "org.jdom" && requested.name == "jdom2") { | ||
| useVersion(libs.versions.jdom2.get()) | ||
| } | ||
| if (requested.group == "org.bitbucket.b_c" && requested.name == "jose4j") { | ||
| useVersion(libs.versions.jose4j.get()) | ||
| } | ||
| if (requested.group == "org.apache.commons" && requested.name == "commons-compress") { | ||
| useVersion(libs.versions.commons.compress.get()) | ||
| } | ||
| if (requested.group == "org.apache.commons" && requested.name == "commons-lang3") { | ||
| useVersion(libs.versions.commons.lang3.get()) | ||
| } | ||
| if (requested.group == "org.mozilla" && requested.name == "rhino") { | ||
| useVersion(libs.versions.rhino.get()) | ||
| } |
Collaborator
There was a problem hiding this comment.
Again, I don't think we should go with this approach (enforcing transitive dependencies).
Let's upgrade what is possible (like AGP) and then let's see if we need to dismiss some of security alets
|
KCeh
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency Updates
AGP and Kotlin updated
Dokka config fixed