Skip to content

Add tests#8

Open
KCeh wants to merge 4 commits into
feature/CIfrom
feature/tests
Open

Add tests#8
KCeh wants to merge 4 commits into
feature/CIfrom
feature/tests

Conversation

@KCeh

@KCeh KCeh commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

I added tests to ensure code quailty. Test check is also added to CI

Changes

  • Tests added
  • Test check added to CI workflow

Type

  • Feature: This pull request introduces a new feature.
  • Bug fix: This pull request fixes a bug.
  • Refactor: This pull request refactors existing code.
  • Documentation: This pull request updates documentation.
  • Other: This pull request makes other changes.

Additional information

  • This pull request introduces a breaking change.

Description

Checklist

  • I have performed a self-review of my own code.
  • I have tested my changes, including edge cases.
  • I have added necessary tests for the changes introduced (if applicable).
  • I have updated the documentation to reflect my changes (if applicable).

Additional notes

@KCeh KCeh self-assigned this Jan 9, 2026
@KCeh KCeh added the enhancement New feature or request label Jan 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive unit tests for the Snacky library and integrates test execution into the CI workflow. The PR introduces test coverage for core components including state management, duration configuration, animation specifications, and data models.

Key Changes:

  • Added unit tests for SnackyHostState, SnackyDuration, SnackyAnimationSpec, and DefaultSnackbarData
  • Configured test dependencies (JUnit, MockK, Kotlinx Coroutines Test)
  • Added test execution job to CI workflow with detailed test logging configuration

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
snacky/src/test/java/com/infinum/snacky/SnackyHostStateTest.kt Tests for snackbar host state management, queuing, callbacks, and duration handling
snacky/src/test/java/com/infinum/snacky/SnackyDurationTest.kt Tests for all duration types and validation logic
snacky/src/test/java/com/infinum/snacky/SnackyAnimationSpecTest.kt Tests for animation configuration and default values
snacky/src/test/java/com/infinum/snacky/DefaultSnackbarDataTest.kt Tests for default snackbar data model properties
snacky/build.gradle.kts Added test dependencies and configured detailed test logging output
gradle/libs.versions.toml Added version declarations for test libraries (JUnit, MockK, Kotlinx Coroutines Test)
.github/workflows/CI.yml Added unit test job to CI workflow with gradle caching

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/CI.yml
Comment thread snacky/src/test/java/com/infinum/snacky/SnackyHostStateTest.kt
Comment thread snacky/src/test/java/com/infinum/snacky/SnackyHostStateTest.kt
Comment thread snacky/src/test/java/com/infinum/snacky/DefaultSnackbarDataTest.kt
Comment thread snacky/src/test/java/com/infinum/snacky/DefaultSnackbarDataTest.kt Outdated
Comment thread snacky/src/test/java/com/infinum/snacky/DefaultSnackbarDataTest.kt Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread snacky/src/test/java/com/infinum/snacky/DefaultSnackbarDataTest.kt Outdated
Comment thread snacky/build.gradle.kts Outdated
@KCeh KCeh requested a review from JonatanPlesko February 27, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants