Conversation
iobrado
added
improvement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
=============================================
+ Coverage 15.24% 45.18% +29.93%
+ Complexity 1201 1138 -63
=============================================
Files 82 79 -3
Lines 4519 4300 -219
=============================================
+ Hits 689 1943 +1254
+ Misses 3830 2357 -1473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
piqusy
left a comment
piqusy
left a comment
There was a problem hiding this comment.
Nice work 👏🏼
Left a few suggestions
Also, can you write tests for t... oh wait 🤣
| $this->assertStringContainsString(' disabled', $result); | ||
| $this->assertStringContainsString(' readonly', $result); |
There was a problem hiding this comment.
Is the empty space intentional here e.g. ' disabled'
There was a problem hiding this comment.
Doesn't seem like it. Removed the empty space and I'm not seeing any difference in coverage
|
|
||
| // Note: Can't easily mock static class methods with Brain Monkey | ||
| // When cache file has invalid JSON, the code throws InvalidManifest exception | ||
| // TODO: Consider if this should be caught and fallback to rebuilding cache |
There was a problem hiding this comment.
Could be that Claude made some reminders to itself 😂
|
@piqusy you reviewed this professionally. I will leave you a ⭐⭐⭐⭐⭐ rating. I addressed the concerns and added some additional tests, further increasing the coverage. |
3 participants
Description
Fixed
Updated
Note: I leveraged Claude to help me out with the tests. The errors are fixed and the coverage is increased, but if you notice any issues with the updates made to the tests, let me know.
Before
After
After after
Even more after
Final after v1