Conversation
There are notably two test cases that we do *not* test: - Writing an empty buffer to a directory - Writing to a directory The reason we do not test these is because these errors are caught by open_at; which is required to be called before we can perform writes (a descriptor *is* required); hence it's impossible to get a write descriptor for a directory.
…ate that it is not currently implemented
Notably, this asserts that if a write is attempted by the python guest we will see ErrorCode::Unsupported. This is because under the hood Python uses write_via_stream; and not write.
Sl1mb0
commented
Mar 14, 2026
| path: "/test", | ||
| err: "OK", | ||
| content: "hello world", | ||
| expected: "ERR: [Errno 58] Not supported", |
Contributor
Author
There was a problem hiding this comment.
Just want to highlight this one. I'll implement write_via_stream in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #337