Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg Integration documentation #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Iceberg Integration documentation #5918
Changes from 30 commits
d92a19c
5d7bc7f
f873263
8391ce7
8b454e0
57c024c
9563143
3f82fb6
0478e05
4a1f036
091c315
a32d724
d22f3fb
0a5d3f5
7bc3352
22c19be
e9345af
4693ece
8ea52b7
836e31b
a4eefaa
3283130
6c55f87
7c6a630
d353d01
677ed17
accaffe
8b8257b
ffc8014
bb7a0d3
05d4858
aa6b36a
7e260b5
bd472c8
1ad0ffa
b022d25
b712851
c5d58ee
9adfbda
37888c0
4e6e034
e79725d
a4e2b80
aebe441
277fcde
07f6551
4b2ee68
0c31daa
6cd3c82
8adec72
92208e4
c9e26fa
cb02320
4d259fb
a8badd6
83b6570
3b56fee
6eed23c
6c09ef4
a013770
905edc3
b4b4a7e
c655971
6034b91
b11788d
6af2b3f
f5d465b
3a44b1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the user instructed to do this? For Cloud Dedicated, they can't. This is something we have to do for them. They would be able to do this in Clustered, but we never tell them to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just internal testing instructions, lets not include these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't assume they've done this. If this is necessary, we need to tell them to create a config.json and then where to put it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritwika314
influxdb_iox
is not something we've encouraged users to use. All client-facing cluster management is done throughinfluxctl
. Are we going to add anything toinfluxctl
to export Iceberg tables for Clustered customers?@MeelahMe This example appears to be for a local test bed and is pulling data from the filesystem. We need to make sure the example is similar to what a customer would run in production, where the source object store is a hosted object store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No these are local testing instructions . i am going through this PR now, sorry i was buried under a lot of notifications and had not noticed this. I will provide detailed feedback by EOD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would describe these in separate bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a little more about what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands should be used in the process above, not
influxdb_iox