-
Notifications
You must be signed in to change notification settings - Fork 322
Dar 588 plugins #6718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jstirnaman
wants to merge
5
commits into
master
Choose a base branch
from
dar-588-plugins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dar 588 plugins #6718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity Fixes issues with plugin filename resolution and improves progressive disclosure in the processing engine Get Started guide. - Update `--plugin` flag to `--path` (current CLI syntax) - Clarify plugin filename must be provided without relative/absolute paths - Add note explaining path resolution relative to `--plugin-dir` - Document single-file vs multi-file plugin path requirements - Link to detailed multi-file plugin structure documentation - Add "Before you begin" section listing required setup steps - Add prerequisites to table of contents - Improve progressive disclosure by front-loading essentials - Update trigger type from "Data write" to "WAL rows" (consistent with `influxdb3 create trigger --help`) with WAL link - Replace `--plugin` with `--path` in trigger creation example - Fix syntax error in enable trigger example (missing backslash) - Clarify plugin example as "data write (WAL) plugin" - Update code comments for clarity and remove outdated notes - Specify "wal_rows trigger specification" terminology - Specify testing "process_writes (WAL) plugin" for clarity - Reference multiple test commands, not just wal_plugin - Add link to schedule_plugin test command - Clarify that PLUGIN_FILENAME should be filename only - Prevents path resolution errors users encountered - Aligns documentation with current CLI behavior - Improves Get Started guide readability and flow - Reduces confusion about plugin file handling Closes #588
- Added inline comments to Docker Compose examples: `# Optional: only needed for processing engine plugins` - Appears for both `--plugin-dir` flag and volume mount - Helps users understand they can skip this if not using plugins - Better progressive disclosure - users see it's optional without needing separate explanation
- Uses `--path` for plugins, replacing deprecated `--plugin-filename` - Replaces "Data write" with "WAL rows" to be consistent with CLI help docs
Contributor
|
Contributor
PR Preview
Pages included in this preview
Preview auto-deploys on push. Will be cleaned up when PR closes. |
jstirnaman
commented
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes influxdata/dar/issues/588