Skip to content

fix: change mapping of /health and /ready to /api/v2/health and /api/v2/ready #19578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: change mapping of /health and /ready to /api/v2/health and /api/v2/ready #19578

wants to merge 2 commits into from

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 17, 2020 •
edited
Loading

Closes #19357

The Cloud version has exposed health and ready endpoint on /api/v2 path:

but OSS version on root path - /.

The swagger.yml definition is used for both so We have to unify this.

Influx CLI

influx CLI doesn't work against cloud instances:

influx ping --host https://us-west-2-1.aws.cloud2.influxdata.com/

Error: Invalid character '<' looking for beginning of value.
See 'influx ping -h' for help
influx ping --host https://us-west-2-1.aws.cloud2.influxdata.com/ --token luvwJXTn...

Error: unknown flag: --token
See 'influx ping -h' for help
  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@bednar bednar marked this pull request as ready for review September 17, 2020 09:14
@bednar bednar requested a review from a team as a code owner September 17, 2020 09:14
@bednar bednar requested review from 121watts and removed request for a team September 17, 2020 09:14
@bednar bednar mentioned this pull request Sep 17, 2020
Closed
@russorat russorat requested review from a team and lyondhill and removed request for a team September 23, 2020 15:56
@rbetts
Copy link
Contributor

rbetts commented Sep 23, 2020

Please do not merge this to cloud. We need to be sure we do not expose internal health information to end-users.

@lyondhill lyondhill removed their request for review October 9, 2020 20:14
@121watts 121watts removed their request for review December 1, 2020 22:09
@bednar bednar mentioned this pull request Jun 21, 2021
Merged
5 tasks
@danxmoran
Copy link
Contributor

This would be a breaking change for the influx CLI, and from the linked issues / my attempt to follow the linked URLs it looks like the /api/v2/health and /api/v2/ready endpoints in Cloud don't have the same behavior as /health and /ready in OSS. Closing this.

@danxmoran danxmoran closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InfluxDB 2 Cloud doesn't expose /health endpoint at root URL
3 participants
@bednar @rbetts @danxmoran