Skip to content

fix(pingEndpoint): change build type to 'oss2', use correct version #21723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2021
Merged

fix(pingEndpoint): change build type to 'oss2', use correct version #21723

merged 3 commits into from
Jun 24, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 21, 2021

This PR fix the /ping endpoint:

  • change build type from cloud2 to oss2
  • use correct version for X-Influxdb-Version header

@bednar bednar marked this pull request as ready for review June 21, 2021 12:04
@bednar bednar requested review from stuartcarnie and rbetts June 21, 2021 12:04
@rbetts rbetts requested review from psteinbachs and removed request for stuartcarnie and rbetts June 22, 2021 13:00
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM but seem unrelated to the originally-linked issues. I've edited the PR description to remove the links so those don't get auto-closed when this merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants