feat(httpd): configurable http read timeout #18928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
suggested changes
Sep 13, 2021
There was a problem hiding this comment.
I think this approach is fine but needs to be updated to fix conflicts.
Stepping back from the PR, which product are you hoping this is released in? We could potentially backport to 1.8, but it would seem more valuable to investigate a fix for 2.x .
Additionally this should really have some sort of test to prove it is working correctly and does not regress (ideally a unit test).
HTTP read timeout is useful to avoid half-open connections due to bad network. See influxdata#15410.
foobar
force-pushed
the
read-timeout
branch
from
369baaa to
95c7960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP read timeout is useful to avoid half-open connections due to
bad network.
Closes #15410