-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: Parquet format output not working in CLI for show commands #25997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Parquet format output not working in CLI for show commands #25997
Conversation
BREAKING CHANGE: The short option -o, previously used for order-by in the table-list command, has been replaced and is now used for the output option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He @Karribalu - I have a couple of suggestions in line. I think the breaking change is okay given the prior discussion about it, and that this makes it consistent with other CLIs that output parquet.
influxdb3/tests/cli/mod.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a success test case that writes the parquet to a temp file, then reads it, and validates its contents.
Some helpful APIs that would enable that:
- We use the
tempfile
crate for temporary files in tests - There are APIs for reading parquet files into Arrow
RecordBatch
s in theparquet
crate - There are helpers for visually asserting on the contents of those record batches in DataFusion, e.g.,
assert_batches_sorted_eq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hiltontj,
Apologies for the late reply.
I have added test cases for validating the parquet files using the resources you provided.
Please let me know if you have any comments.
…utput-format is parquet
@Karribalu - sorry that we have not followed up on this PR until now. I will have to request some more changes in order to get this merged:
|
BREAKING CHANGE:
The short option -o, previously used for order-by in the table-list command, has been replaced and is now used for the output option.
Closes #25941
Describe your proposed changes here.