feat: Add WaitWithTimeout to Partition and WaitGroupTimeout #26294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes it easier to debug potential hanging retention service routines during DeleteShard.
pkg/wg_timeout/wg_timeout.go
Outdated
| func WaitGroupTimeout(wg *sync.WaitGroup, timeout time.Duration) bool { | ||
| c := make(chan struct{}) | ||
|
|
||
| go func() { |
There was a problem hiding this comment.
take unidirectional channel as parameter
pkg/wg_timeout/wg_timeout.go
Outdated
| case <-c: | ||
| return false | ||
| case <-timer.C: | ||
| return true |
There was a problem hiding this comment.
Log here, but do not exit.
pkg/wg_timeout/wg_timeout.go
Outdated
| "time" | ||
| ) | ||
|
|
||
| func WaitGroupTimeout(wg *sync.WaitGroup, timeout time.Duration) bool { |
There was a problem hiding this comment.
I would take a zap.Logger and a message here. Print the message at Warn level each time around the loop, with the total elapsed duration as a zap field. No return value - make this like Wait
I would not return on timer ticks; that will change the behavior of the system. Just log the wait.
Style suggestion: take c as an argument to the lambda, restricting its directionality, and renaming it.
devanbenz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to debug potential hanging retention service routines during DeleteShard.