Skip to content

feat: improve dropped point logging #26303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Conversation

davidby-influx
Copy link
Contributor

@davidby-influx davidby-influx commented Apr 22, 2025

Log the reason for a point being dropped,
the type of boundary violated, and the
time that was the boundary. Prints the
maximum and minimum points (by time)
that were dropped

closes #26252

  • fix: better time formatting and additional testing

  • fix: differentiate point time boundary violations

  • chore: clean up switch statement

  • fix: improve error messages

(cherry picked from commit 62e803e)

closes #26295

Log the reason for a point being dropped,
the type of boundary violated, and the
time that was the boundary. Prints the
maximum and minimum points (by time)
that were dropped

closes #26252

* fix: better time formatting and additional testing

* fix: differentiate point time boundary violations

* chore: clean up switch statement

* fix: improve error messages

(cherry picked from commit 62e803e)

closes #26295
@davidby-influx davidby-influx self-assigned this Apr 22, 2025
@davidby-influx davidby-influx linked an issue Apr 22, 2025 that may be closed by this pull request
@davidby-influx davidby-influx changed the title Dsb dropped logging 2 feat: improve dropped point logging Apr 22, 2025
@davidby-influx davidby-influx force-pushed the DSB_dropped_logging_2 branch from 1328d31 to ff06088 Compare April 22, 2025 02:02
@davidby-influx davidby-influx marked this pull request as ready for review April 22, 2025 04:15
Copy link

@devanbenz devanbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidby-influx davidby-influx merged commit eebe655 into main-2.x May 6, 2025
25 checks passed
@davidby-influx davidby-influx deleted the DSB_dropped_logging_2 branch May 6, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve dropped point logging [port to main-2.x]
2 participants