-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: port from enterprise to core #26991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings several prs from enterprise into core. Most of volume is for improved error handling, but there are features: * proper gzip multipayload support * don't panic if there's an issue with the plugin dir * improved resource not found messaging * truncating user provided information in logging and errors * cluster uuid header in all api responses
a6e3e7f to
54d8da4
Compare
philjb
commented
Nov 23, 2025
| } | ||
|
|
||
| /// Wrapper for HttpApi used by the recovery endpoint that includes a shutdown token | ||
| pub(crate) struct RecoveryHttpApi { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just moved location in the file
philjb
commented
Nov 23, 2025
| Ok(response) | ||
| } | ||
|
|
||
| fn extract_client_ip<T>(req: &http::Request<T>) -> Option<String> { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved locations; see above.
hiltontj
approved these changes
Nov 25, 2025
philjb
added a commit
that referenced
this pull request
Nov 27, 2025
This ports a number of changes from enterprise to core. Primarily this adds a new telemetry field for how influxdb3 has been started (aka invocatio method). Most of the changes are to sync core code with the shape of ent code to make future ports easier. There are some error reporting improvements and logging improvements mixed in there too. * follows #26991
philjb
added a commit
that referenced
this pull request
Nov 27, 2025
This ports a number of changes from enterprise to core. Primarily this adds a new telemetry field for how influxdb3 has been started (aka invocatio method). Most of the changes are to sync core code with the shape of ent code to make future ports easier. There are some error reporting improvements and logging improvements mixed in there too. * follows #26991
philjb
added a commit
that referenced
this pull request
Nov 27, 2025
This ports a number of changes from enterprise to core. Primarily this adds a new telemetry field for how influxdb3 has been started (aka invocation method). Most of the changes are to sync core code with the shape of ent code to make future ports easier. There are some error reporting improvements and logging improvements mixed in there too. * follows #26991
philjb
added a commit
that referenced
this pull request
Dec 1, 2025
* feat(port): port from ent to core This ports a number of changes from enterprise to core. Primarily this adds a new telemetry field for how influxdb3 has been started (aka invocation method). Most of the changes are to sync core code with the shape of ent code to make future ports easier. There are some error reporting improvements and logging improvements mixed in there too. * follows #26991 * refactor: copilot pr feedback --------- Co-authored-by: Trevor Hilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings several prs from enterprise into core. Most of volume is for improved error handling, but there are features:
Ports most of or parts of
feat(http errors): improve error messages for not foundrefactor(http): centralize error handling through RoutingError enumfeat(http): include cluster-uuid in response header for all requestschore(errors): refine errors and loggingchore: improve error reporting for processing engineeat(server,http): accept multi-member gzip payloadsfeat: populate lvc dvc on creationfix: Error if plugin_dir is set with no pip/uv