chore: ignore Authorization header when building request plugin headers #27013
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs (#1890) While authenticate_request() already removes the Authorization header, explicitly skip adding the Authorization header when building up the request plugin's 'request_headers' headers that is passed into the 'process_request()' python API. This hardens the codebase from accidentally adding it back and allowing the request plugin to use the Authorization header to hit the HTTP API through the front door, bypassing it's intended API. Co-authored-by: Claude <[email protected]>
philjb
approved these changes
Dec 8, 2025
jdstrand
deleted the
jdstrand/explicitly-remove-authorization-header-for-request-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While authenticate_request() already removes the Authorization header, explicitly skip adding the Authorization header when building up the request plugin's 'request_headers' headers that is passed into the 'process_request()' python API. This hardens the codebase from accidentally adding it back and allowing the request plugin to use the Authorization header to hit the HTTP API through the front door, bypassing it's intended API.
Clean cherry-pick from influxdb_pro