feat: add ping endpoint #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
reviewed
Jun 24, 2021
contracts/cloud.yml
Outdated
Comment on lines
61
to
62
| get: | ||
| operationId: PostPing |
There was a problem hiding this comment.
should this be a post or get?
There was a problem hiding this comment.
It should be GetPing... fixed
glinton
suggested changes
Jun 24, 2021
src/common/paths/ping.yml
Outdated
| @@ -0,0 +1,30 @@ | |||
| get: | |||
| operationId: PostPing | |||
There was a problem hiding this comment.
Can you make these operationIds unique?
glinton
approved these changes
Jul 8, 2021
| description: The type of InfluxDB build. | ||
| X-Influxdb-Version: | ||
| schema: | ||
| type: integer |
There was a problem hiding this comment.
looks like this is actually a float, small enough nit i'll merge this
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users of our client libraries (
java,python,ruby, ...) wants to do three things with our libraries:query,writeand check the status of InfluxDB.The query and writes are fine, but the checking status by
/healthendpoint brings trouble because the mapping is different forossandcloudversion. For more info see - influxdata/influxdb#19357As a solution this PR expose the
/pingendpoint which works correctly in OSS and also in Cloud.