test(inputs.redfish): Extend coverage in preparation of lib change#19163
test(inputs.redfish): Extend coverage in preparation of lib change#19163inhinias wants to merge 7 commits into
Conversation
| ComputerSystemID: "System.Embedded.2", | ||
| ComputerSystemID: "1", |
There was a problem hiding this comment.
Can we please keep the previous version?
| } | ||
|
|
||
| func TestIncludeTagSetsConfiguration(t *testing.T) { | ||
| t.Skip("Datacenter tag removed, not part of redfish. Fix will arrive later") |
There was a problem hiding this comment.
Hmmm... The test should not fail, at least not if you don't change the plugin code, should it? If this is an issue arising when changing the underlying lib, please add the "skip" with that PR to document it is breaking things...
| "rack": "", | ||
| "room": "", | ||
| "row": "", | ||
| "datacenter": "", |
There was a problem hiding this comment.
Please don't change existing tests! Those are there for making sure your changes are backward compatible and thus should not be changed. If you need to change an existing test it means your plugin modifications are breaking!
Same for the other occurrences below.
|
@inhinias I marked the resolved items as "resolved". However, there are three issues left... |
|
@srebhan SystemID, Datacenter Tags and test skip reverted. |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
Since the plan is to move to the gofish lib we extend the tests to work with them in a later pr.
Because gofish expects to move from the top of the api to lower nodes, every testcase requires
/redfish/v1/ & /redfish/v1/Systems/ to be present.
Also gofish does no trigger an invalid Response with a trailing "{". Therefore its moved to the start of the data.
Datacenter is supposed to be under the Postal address: tags["datacenter"] = chassis.Location.PostalAddress.DataCenter but its nowhere to be found in the standard. See page 35.
It should be considered if the "room" tag should be changed too since PostalAddress is deprecated.
This pr removes just the datacenter tag from the tests but not the actual program. That test would fail and is therefor skipped. Please inform me on how to handle this case for the "moving to gofish" pr.
Also i already added the testdata for the subsystems that will be added as a feature later.
Checklist
Related issues
Related to: #18963