Skip to content

fix(inputs.jti_openconfig_telemetry): Remove duplicate sensors key#19206

Open
jstirnaman wants to merge 1 commit into
influxdata:masterfrom
jstirnaman:telegraf-pr/jti-duplicate-sensors
Open

fix(inputs.jti_openconfig_telemetry): Remove duplicate sensors key#19206
jstirnaman wants to merge 1 commit into
influxdata:masterfrom
jstirnaman:telegraf-pr/jti-duplicate-sensors

Conversation

@jstirnaman

@jstirnaman jstirnaman commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

The sample config defined sensors twice, which is invalid TOML (duplicate key)
and fails to load. Comment out the alternative group-reporting-rate form so only
one sensors key is active.

The change is made in sample.conf and the README is regenerated, per the
guidance on #18830.

Found while adding code-block linting to the InfluxData docs site, which
generates the published plugin docs from these READMEs.

Verified in Telegraf 1.39.1: before, line 34: key 'sensors' is in conflict with line 25; after, the config loads (Loaded inputs: jti_openconfig_telemetry).

Checklist

Related issues

Related to #19201 (tracking issue for this cleanup; item resolved in this PR)

The sample config defined sensors twice, which is invalid TOML (duplicate
key) and fails to load. Comment out the alternative group-reporting-rate
form so only one sensors key is active, and regenerate the README.
@telegraf-tiger telegraf-tiger Bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 30, 2026
@jstirnaman jstirnaman marked this pull request as ready for review June 30, 2026 18:46
@skartikey skartikey changed the title fix(inputs.jti_openconfig_telemetry): remove duplicate sensors key fix(inputs.jti_openconfig_telemetry): Remove duplicate sensors key Jul 1, 2026
@skartikey

Copy link
Copy Markdown
Contributor

@jstirnaman The sample.conf declared sensors twice (the simple list at line 22 and the group-reporting-rate list at line 30), which is a duplicate TOML key and fails to load. Commenting out the second form as an alternative and regenerating the README is the right minimal fix. The sample.conf and generated README.md hunks match, so make docs is consistent. CI is green.

One optional nit: INSTEAD is upper-cased for emphasis while the surrounding sample-config comments are all sentence-case prose; lowercasing it would read more consistently. Non-blocking.

@skartikey skartikey self-assigned this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants