Resource and Data Source Implementation for Network Template #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nios into networktemplate
…nios into networktemplate
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive resource and data source support for Network Templates in the NIOS provider, enabling users to create, read, update, and delete network template objects with extensive configuration options for DHCP, DDNS, IPAM, and other network settings.
Key Changes
- Added complete CRUD operations for
nios_ipam_networktemplateresource with support for 60+ configuration attributes - Implemented data source for querying network templates with filter and extensible attribute support
- Updated vendor dependencies to include the new
Structfield inNetworktemplateMembersmodel - Added comprehensive test coverage with 70+ test cases covering all major attributes
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/modules.txt, go.mod, go.sum | Updated infoblox-nios-go-client dependency to version with NetworktemplateMembers.Struct field |
| vendor/.../model_networktemplate_members.go | Added Struct field with getter/setter methods for member type identification |
| internal/service/ipam/networktemplate_resource.go | Implemented resource with CRUD operations, validation logic for options and members |
| internal/service/ipam/model_networktemplate.go | Core model with 60+ attributes for network template configuration |
| internal/service/ipam/model_networktemplate_*.go | Supporting models for nested objects (options, members, delegated_member, etc.) |
| internal/service/ipam/networktemplate_resource_test.go | Comprehensive test suite with 70+ test cases for all attributes |
| internal/service/ipam/networktemplate_data_source*.go | Data source implementation with filter support and tests |
| internal/provider/provider.go | Registered new resource and data source with provider |
| examples/, docs/ | Documentation and usage examples for resource and data source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
VishrutiBuddhadev
left a comment
VishrutiBuddhadev
left a comment
There was a problem hiding this comment.
LGTM. @JchhatbarInfoblox Please take a look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.