Implementation of List Functionality for DNS Records (Part 2)#524
Open
unasra wants to merge 9 commits into
Open
Implementation of List Functionality for DNS Records (Part 2)#524unasra wants to merge 9 commits into
unasra wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Terraform Plugin Framework List resources for additional DNS record types and updates corresponding DNS resources to support mutable identity (ref-based) import/list interoperability.
Changes:
- Implement list resources for DNS MX, NAPTR, NS, SRV, TXT records and register them in the provider.
- Add
ResourceWithIdentitysupport to the corresponding DNS resources (identity schema + setting identity during CRUD + identity-aware import). - Add acceptance tests, examples, and generated docs for the new list resources.
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/service/dns/record_txt_resource.go | Adds identity schema + mutable identity behavior and sets identity during CRUD/import for TXT records. |
| internal/service/dns/record_txt_list.go | New list resource for TXT records (filters/extattrfilters, pagination, optional include_resource). |
| internal/service/dns/record_txt_list_test.go | Acceptance tests for TXT list resource (basic/filters/extattrfilters). |
| internal/service/dns/record_srv_resource.go | Adds identity schema + mutable identity behavior and sets identity during CRUD/import for SRV records. |
| internal/service/dns/record_srv_list.go | New list resource for SRV records (filters/extattrfilters, pagination, optional include_resource). |
| internal/service/dns/record_srv_list_test.go | Acceptance tests for SRV list resource (basic/filters/extattrfilters). |
| internal/service/dns/record_ns_resource.go | Adds identity schema + mutable identity behavior and sets identity during CRUD/import for NS records. |
| internal/service/dns/record_ns_list.go | New list resource for NS records (filters, pagination, optional include_resource). |
| internal/service/dns/record_ns_list_test.go | Acceptance tests for NS list resource (basic/filters). |
| internal/service/dns/record_naptr_resource.go | Adds identity schema + mutable identity behavior and sets identity during CRUD/import for NAPTR records. |
| internal/service/dns/record_naptr_list.go | New list resource for NAPTR records (filters/extattrfilters, pagination, optional include_resource). |
| internal/service/dns/record_naptr_list_test.go | Acceptance tests for NAPTR list resource (basic/filters/extattrfilters). |
| internal/service/dns/record_mx_resource.go | Adds identity schema + mutable identity behavior and sets identity during CRUD/import for MX records. |
| internal/service/dns/record_mx_list.go | New list resource for MX records (filters/extattrfilters, pagination, optional include_resource). |
| internal/service/dns/record_mx_list_test.go | Acceptance tests for MX list resource (basic/filters/extattrfilters). |
| internal/service/dns/model_record_a.go | Small formatting fix in Record A schema validator list. |
| internal/provider/provider.go | Registers the new DNS list resources with the provider. |
| examples/list-resources/nios_dns_record_txt/list-resource.tfquery.hcl | Adds TXT list resource query examples. |
| examples/list-resources/nios_dns_record_srv/list-resource.tfquery.hcl | Adds SRV list resource query examples. |
| examples/list-resources/nios_dns_record_ns/list-resource.tfquery.hcl | Adds NS list resource query examples. |
| examples/list-resources/nios_dns_record_naptr/list-resource.tfquery.hcl | Adds NAPTR list resource query examples. |
| examples/list-resources/nios_dns_record_mx/list-resource.tfquery.hcl | Adds MX list resource query examples. |
| docs/list-resources/dns_record_txt.md | Generated docs for TXT list resource. |
| docs/list-resources/dns_record_srv.md | Generated docs for SRV list resource. |
| docs/list-resources/dns_record_ns.md | Generated docs for NS list resource. |
| docs/list-resources/dns_record_naptr.md | Generated docs for NAPTR list resource. |
| docs/list-resources/dns_record_mx.md | Generated docs for MX list resource. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.