fix: remove header check in detect_misbehaviour#4414
Open
JayT106 wants to merge 1 commit intoinformalsystems:masterfrom
Open
fix: remove header check in detect_misbehaviour#4414JayT106 wants to merge 1 commit intoinformalsystems:masterfrom
JayT106 wants to merge 1 commit intoinformalsystems:masterfrom
Conversation
thomas-nguy
reviewed
Oct 9, 2025
|
|
||
| // No header in events, cannot run misbehavior. | ||
| // May happen on chains running older SDKs (e.g., Akash) | ||
| if update_event.header.is_none() { |
There was a problem hiding this comment.
Removing the check alone won’t fix the problem, since the header is still required by detect_misbehaviour to compare it with the client state header.
Following the comment, we should call the /header endpoint to retrieve the header instead of relying on the event data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4413
PR author checklist:
unclog.docs/).mircea-cReviewer checklist:
Files changedin the GitHub PR explorer.