Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl #[derive(UserData)] and improve naming #284

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Impl #[derive(UserData)] and improve naming #284

merged 4 commits into from
Feb 17, 2025

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Jan 18, 2025 •
edited
Loading

  • Rename SequenceMsg to Sequenced
  • Rename MsgSansHandler to Noop
  • Impl #[derive(UserData)]

@hu55a1n1 hu55a1n1 marked this pull request as ready for review January 27, 2025 12:45
@dangush dangush self-requested a review February 14, 2025 07:38
dangush
dangush approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@dangush dangush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Any thoughts on a name for Noop that pairs with "sequenced" more closely? Like Direct?

@hu55a1n1
Copy link
Member Author

Any thoughts on a name for Noop that pairs with "sequenced" more closely? Like Direct?

Yeah not the best name for sure. I just wanted to keep it short. Open to suggestions. 😅
(Noop was previously called MsgSansHandler to signify that this message does not trigger a quartz on-chain handler so it is noop in that sense.)

@hu55a1n1 hu55a1n1 merged commit 7eae28b into main Feb 17, 2025
8 checks passed
@hu55a1n1 hu55a1n1 deleted the hu55a1n1/v0_2-contract branch February 17, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangush dangush dangush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hu55a1n1 @dangush