Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ITF not being produced on successful runs #1362

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented Feb 8, 2024

Hello :octocat:

@p-offtermatt just reported a problem on slack where we stopped producing ITF on successful runs - we are currently only producing them in violations. This fixes the problem and adds an integration test for this previously uncovered scenario.

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality
  • Feature table on README.md updated for any listed functionality

@bugarela bugarela requested a review from shonfeder February 8, 2024 11:54
@bugarela bugarela self-assigned this Feb 8, 2024
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick fix!

@bugarela bugarela merged commit 5248470 into main Feb 8, 2024
15 checks passed
@bugarela bugarela deleted the gabriela/fix-itf-output-on-success branch February 8, 2024 13:34
@shonfeder shonfeder mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants