Correctly constrain parameter types based on annotations #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
commented
Feb 14, 2024
| @@ -108,6 +110,32 @@ export interface QuintApp extends WithId { | |||
| args: QuintEx[] | |||
| } | |||
|
|
|||
| // Not an expression, but still carries the base expression data | |||
There was a problem hiding this comment.
This was mainly only moved up to be right after the other expression types.
Instead of flagging the entire declaration as erroneous, we only indicate the problematic expression now.
shonfeder
force-pushed
the
1177/prioritize-annotation-resolution
branch
from
e494b1d to
e380b2a
Compare
|
Closed in favor of #1371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177
This would also open the way to supporting inline type annotations, like
However we discussed an alternative fix for #1177 that may be less invasive, so
I'll see if I can prep a PR for that tomorrow.
CHANGELOG.mdfor any new functionalityREADME.mdupdated for any listed functionality