OP-1429 Make the operation result compulsory on insert - #1644
Open
giuseppesorge wants to merge 2 commits into
Open
OP-1429 Make the operation result compulsory on insert#1644giuseppesorge wants to merge 2 commits into
giuseppesorge wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OP-1429 (Improve the Operations management GUI in the admission workflow): https://openhospital.atlassian.net/browse/OP-1429
Spun off from OP-1404. Makes the operation-row result mandatory on insert in
OperationRowBrowserManager.validateOperationRow:newOperationRowrejects an empty/null result, whileupdateOperationRowkeeps it length-checked only, so legacy rows (and the GUI re-submitting every existing row on each save) stay editable. Uses the existingangal.operationrow.pleaseselectaresult.msgkey added by OP-1404.Unit tests: empty/null result rejected on insert, empty result tolerated on update.
Companion PRs: gui informatici/openhospital-gui#2235 · doc informatici/openhospital-doc#293