Conversation
|
|
…m/informatik-mannheim/HSMA-CTT into feature/new_store_check_in_cookie
|
I did some testing and everything seems fine. While reviewing your code i got stuck on the CookieManager class. Not sure if i understand what you are doing there, either you lead me through this or someone with experience in Cookie managing with javax should review this file. |
| @@ -0,0 +1,40 @@ | |||
| .danger-color { | |||
There was a problem hiding this comment.
Am I right that this file is only used for the "still checked in message"? Then pls give it a more descriptive name such as checked-in-alert.css or so.
| @@ -0,0 +1,7 @@ | |||
| const checkInAlertForm = document.getElementById('check-in-alert-form') | |||
There was a problem hiding this comment.
I would also prefer a more descriptive name here.
| flex-direction: column; | ||
| border: 2px solid #22376F; | ||
| border-radius: 3px; | ||
| margin: 5px; |
There was a problem hiding this comment.
May I suggest a somewhat larger margin below the box? Currently it is somewhat close to the regular text on the page. (not sure this is the right margin attribute though)
Added a period at the end of the sentence.
Period added.
| @@ -28,8 +28,17 @@ <h1 style="margin-left: 0.42em; margin-top: 0.15em"> | |||
| </div> | |||
There was a problem hiding this comment.
@MorMundHS-MA I would assume that this checkout-bar div and its CSS definition in main.css can be savely removed, can't it?
There was a problem hiding this comment.
If I understand the implementation correctly, the cookie handler adds the attribute to any request. In that case I assume this layout template should also have the checkout button since it doesn't use the template of the dashboard/landing page.
| @@ -0,0 +1,151 @@ | |||
| /* | |||
There was a problem hiding this comment.
Didn't we manage cookies in a much simpler fashion before this? Can you briefly explain, why this is neccessary, pls?
| @@ -0,0 +1,51 @@ | |||
| /* | |||
There was a problem hiding this comment.
Why do we need an Interceptor here?
4 participants
Related Issue
Proposed Changes
Additional Info
Checklist