[NEW] make the contact mail addresses a environement variable

[maxones25]

Related Issue

Proposed Changes

Additional Info

Checklist

• Is the code formatted correctly?
• Unnecessary comments removed?
• Printout statements removed?
• If you made backend changes: Did all tests pass? Do you need to adjust some tests or write new ones?
• If you made frontend changes: Did you test the UI on different devices/ browsers (Firefox, Chrome, Safari, different smartphone sizes)
• Is your code easy to understand or do you need to insert some comments?
• Explain the issue for the reviewer and your steps to solve the issue => makes it a lot more easy for the reviewer
• Label your pull request (frontend/ backend/ testing/ styling/ sql/...)
• Is the open source message included at the very beginning of every source code file?
• Are all imports organized, i.e. are the imports up to date and have all package imports been removed?

[MorMundHS-MA]

Looks good, the regex change isn't a must-have but the error handling should be improved.

I assume the idea is to allow other schools/organizations use the app more easily. If so we should use proper internationalization to allow customization of the text on the website. https://www.baeldung.com/spring-boot-internationalization

[MorMundHS-MA]

I think its more readable using a regex to split the e-mail.

    private static final Pattern email_splitter_regex = Pattern.compile("(.*)@(.*)\\.(.*)$");

    public static MailAddress parse(String mailAddress) throws InvalidEmailException {
        val match = email_splitter_regex.matcher(mailAddress);
        if(!match.matches()) {
            throw new InvalidEmailException();
        }

        val name = match.group(1);
        val domain = match.group(2);
        val tld = match.group(3);
        return new MailAddress(mailAddress, name, domain, tld);
    }

[MorMundHS-MA]

There already is an InvalidEmailException. But it probably should be more explicit about this being a configuration error vs. a user entering an invalid email. Maybe using a default email like invalid-email@invalid.org + logging an error makes more sense.

[oliverhummel]

Am I getting this right, that this class and the whole parsing is only done to decompose the mail address for the mail obfuscation used in the frontend? Wouldn't it be easier to decompose this manually in the properties file and access the elements from the frontend directly? (like so: https://stackoverflow.com/questions/56102116/access-application-properties-value-in-thymeleaf-template)

[maxones25]

yes, you could also enter the email address already split into the properties. I thought that might be a bit more comfortable in the configuration if the splitting happens automatically.