Skip to content

update change log#213

Merged
halcwb merged 9 commits intoinformedica:masterfrom
halcwb:master
Mar 23, 2026
Merged

update change log#213
halcwb merged 9 commits intoinformedica:masterfrom
halcwb:master

Conversation

@halcwb
Copy link
Collaborator

@halcwb halcwb commented Mar 23, 2026

This pull request introduces several major improvements across the server, client, tests, and build process, with a focus on architecture modernization, test coverage, and developer tooling. The most significant changes include a modular server architecture, enhanced agent and error handling, migration of test scaffolding into CI suites, and the adoption of Fantomas for code formatting.

Server Architecture & Functionality:

  • Switched the server to a bounded domain modular architecture, reorganizing modules as independent bounded contexts for better cohesion and testability. Legacy code has been removed.
  • Added graceful shutdown support to the server, ensuring clean termination of active agents and connections on SIGTERM/SIGINT.
  • Improved error handling in the GenForm server module for cases where resources (Google Sheets / CSV) cannot be loaded.
  • Converted processOrderPlanCommand and processNutritionCommand to use let! for async calls instead of Async.RunSynchronously, preventing thread-pool starvation.
  • Introduced Agent.createReplyAsync, allowing for non-blocking async agent workflows.

Testing Improvements:

  • Migrated test scaffolding for GenFORM, GenORDER, and NKF into formal CI test suites, adding hundreds of lines of new Expecto tests for improved coverage and automation.
  • Removed legacy W3 analysis and test scaffolding scripts, as their content has been fully migrated to the new CI test suites.

Build & Developer Tooling:

  • Added a Fantomas pre-commit hook to auto-format F# source files on every commit, and updated .fantomasignore to exclude client UI code.
  • Applied Fantomas formatting to all F# source files (formatting-only, no logic changes), and updated documentation to reflect the new formatting configuration.

Client & Dependency Updates:

  • Updated the client UI to the latest Fable releases and patched Feliz.Router for compatibility.
  • Updated Fable and applied Fantomas formatting to client UI code.

Repo Assist and others added 6 commits March 23, 2026 20:30
…ssues

- Add entries for safe-and-clean server architecture (PR informedica#204)
- Add Fable update (PR informedica#205)
- Add GenFORM/GenORDER/NKF tests migrated to CI (PR informedica#206)
- Add graceful shutdown (PR informedica#207)
- Add Fantomas formatter pre-commit hook (PR informedica#208/informedica#209)
- Fix '+' prefixes on 3 lines (leftover diff markers from PR #16 merge)
- Remove 2 duplicate entries (GenOrderTestScaffolding, Server/GenForm)
- Add Removed section for cleaned-up W3 analysis scripts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ch-2026-f4fe78b8576455b6

[Repo Assist] docs(changelog): add 23 March 2026 changes and fix format issues
[WIP] [Repo Assist] Update CHANGELOG for March 23 2026 changes
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 23, 2026

Greptile Summary

This PR updates CHANGELOG.md to document several improvements across server architecture, testing, build tooling, and client dependencies. The entries are well-described, but the diff introduces four structural issues in the changelog that should be corrected before merging.

Key issues found:

  • Missing blank line between the last [Unreleased] bullet and the --- section divider (minor Markdown formatting).
  • The [0.1.2-alpha] block now contains two ### Fixed sections — the new one was inserted immediately above the pre-existing one instead of being merged into it.
  • - **Dependencies**: Update Fable to latest version (PR #205) and - **Build**: Apply Fantomas formatting to client UI code (PR #209) were originally in ### Changed but are now orphaned under the new ### Fixed heading due to the insertion point.
  • - **Server/GenForm**: Improve error handling when resources (Google Sheets / CSV) cannot be loaded is now duplicated: once in ### Added (added by this PR) and once in the pre-existing ### Fixed section of [0.1.2-alpha].

Confidence Score: 3/5

  • Safe to merge after resolving four structural issues in the changelog (duplicate section, misplaced entries, duplicate item, missing blank line).
  • All issues are documentation-only and confined to CHANGELOG.md, but there are four concrete structural problems (duplicate ### Fixed section, two items mis-categorised from Changed to Fixed, one entry duplicated across Added and Fixed, missing blank line) that leave the changelog in an inconsistent state for readers and tooling that parses it.
  • CHANGELOG.md — the [0.1.2-alpha] block has structural errors introduced by the insertion.

Important Files Changed

Filename Overview
CHANGELOG.md Adds [Unreleased] and [0.1.2-alpha] entries, but introduces a missing blank line before the separator, a duplicate ### Fixed section, two items mis-moved from ### Changed into ### Fixed, and a duplicate Server/GenForm entry under both ### Added and ### Fixed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["[Unreleased] ### Added"] -->|"missing blank line"| SEP["--- separator"]
    SEP --> B["[0.1.2-alpha]"]

    B --> ADD["### Added"]
    ADD -->|"duplicate entry ⚠️"| DUPE["Server/GenForm error handling"]

    B --> CHG["### Changed\n(Build + Docs — new entries)"]
    B --> REM["### Removed\n(Scripts)"]
    B --> FIX1["### Fixed (NEW — inserted by PR)"]
    FIX1 -->|"should be in ### Changed ⚠️"| MIS1["Dependencies: Update Fable"]
    FIX1 -->|"should be in ### Changed ⚠️"| MIS2["Build: Fantomas client UI"]
    B --> FIX2["### Fixed (PRE-EXISTING)"]
    FIX2 --> DUPE2["Server/GenForm error handling (duplicate ⚠️)"]
    FIX2 --> OK["Tests / GenOrder / Client fixes"]
Loading

Comments Outside Diff (1)

  1. CHANGELOG.md, line 56-65 (link)

    P2 Duplicate ### Fixed section in [0.1.2-alpha]

    The [0.1.2-alpha] release block now contains two separate ### Fixed sections (lines 56 and 62). This PR inserted a new ### Fixed heading and one entry just above the pre-existing ### Fixed block, resulting in two consecutive sections with the same heading. Keep a Changelog allows only one subsection per category per release. The entries should be merged into a single ### Fixed section.

    Fix in Claude Code

Fix All in Claude Code

Reviews (1): Last reviewed commit: "Merge pull request #18 from halcwb/copil..." | Re-trigger Greptile

halcwb and others added 3 commits March 23, 2026 23:49
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@halcwb halcwb merged commit 9f92684 into informedica:master Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants