fix(update): remove 60s download timeout that fails on slow connections#118
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
davide-baldo
approved these changes
May 29, 2026
liamg
approved these changes
May 29, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http.Client{Timeout: 60s}applies a wall-clock deadline over the entire HTTP lifecycle — connection, redirect, and body read. Downloading a 30–50 MB binary archive over a slow connection easily exceeds this, causingfailed to read asset: context deadline exceeded.Replaced with
http.DefaultClient(no hard timeout). Thectxpassed toDownloadReleaseAssetalready handles user cancellation (Ctrl+C).🤖 Generated with Claude Code