fix: skip .sha256 assets when building plugin manifest#83
Merged
liamcervante merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
The asset regex matched both `<plugin>-<os>-<arch>.tar.gz` and the matching `.sha256` checksum file, producing the same `<os>_<arch>` map key. The checksum entry overwrote the archive, so plugin install tried to unpack the .sha256 text file.
aliscott
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin manifest generator's asset regex matched both
<plugin>-<os>-<arch>.tar.gzand the matching.sha256checksum file, and both produced the same<os>_<arch>map key. The checksum entry overwrote the archive, so the plugin install path was downloading and trying to unpack the.sha256text file.This skips assets ending in
.sha256before they reach the regex.Existing manifest entries that already point at
.sha256URLs will need to be regenerated by re-running the manifest update workflow.