add XMLparser recover option for client; keep default behavior same: recover=False#39
Open
sdm7g wants to merge 1 commit into
Open
add XMLparser recover option for client; keep default behavior same: recover=False#39sdm7g wants to merge 1 commit into
sdm7g wants to merge 1 commit into
Conversation
|
👍 |
wetneb
approved these changes
Apr 26, 2019
Collaborator
wetneb
left a comment
There was a problem hiding this comment.
Looks good to me! Merging soon unless there are any concerns.
|
Looks good to me! Mergeable in my opinion @jascoul, would love to bring down the use of forks with patches for ppl like @bloomonkey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option in Client and BaseClient to use
recover=Trueoption on etree.XMLParser, so that OAI harvesting won't fail on a bad metadata payload.Default is
recover=False, so that it doesn't change any existing behavior ( Making the conservative choice here, just in case anyone is relying on catching failures to validate feeds. )Initially, I tried parsing first with recover=False, catching errors and then retrying with recover=True, but I discovered that was unnecessary.
That will output a line like this, for example, on an unescaped ampersand:
CRITICAL:root:<string>:47:219:FATAL:PARSER:ERR_ENTITYREF_SEMICOL_MISSING: EntityRef: expecting ';'lxml documents how that message can be changed or filtered, if for example, you want to change those 'CRITICAL' to 'WARNING' , but I didn't think that was worth adding to the base code if it's not already using logging module.