Implement readonly on LionSwitchButton#2783
Open
ing-athirlwall wants to merge 4 commits into
Open
Conversation
ing-athirlwall
requested review from
Knorgias,
gerjanvangeest,
narzac,
okadurin,
ryubro and
tlouisse
as code owners
🦋 Changeset detectedLatest commit: f62acfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Alex Thirlwall seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
Please add a changeset |
okadurin
approved these changes
Jun 16, 2026
tlouisse
approved these changes
Jun 16, 2026
added 2 commits
June 16, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Implement readonly property on LionSwitchButton
Why
Allows consumers to style "disabled" differently to "readonly".
"disabled" switches can appear greyed out while "readonly" switches can be normally styled but unusable