ordeq: fix sink="none" with user patches
#377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where user-provided IO patches (via the io parameter) were being incorrectly overridden when save="none" was specified in the run() function.
Summary of changes:
- Reversed the order of patch application in
_runner.pyto ensure user patches take precedence over save mode patches - Added comprehensive test cases to verify the fix works correctly across different save modes
- Updated snapshots to reflect the corrected behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/ordeq/src/ordeq/_runner.py |
Fixed patch ordering so user patches override save mode patches (line 266) |
packages/ordeq/tests/resources/runner/graph.py |
Added test cases for different save modes including the critical save="none" with user patches scenario |
packages/ordeq/tests/snapshots/runner/graph.snapshot.md |
Updated snapshot to reflect correct behavior where R5 is now populated when using user patches with save="none" |
packages/ordeq/tests/snapshots/typing.snapshot.md |
Updated with additional type errors from the new test runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.