Skip to content

ordeq: more informative error for nodes with kw-only args w/o default #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nielsneerhoff merged 5 commits into from
Dec 12, 2025
Merged

ordeq: more informative error for nodes with kw-only args w/o default #516

nielsneerhoff merged 5 commits into from
Dec 12, 2025

Conversation

@nielsneerhoff
Copy link
Member

@nielsneerhoff nielsneerhoff commented Dec 11, 2025 •
edited
Loading

Before this PR the error for nodes with keyword only args without default was too generic:

ValueError: Inputs invalid for function arguments of view 'func2' in module '__main__'

Now it clearly indicates what's wrong:

ValueError: Keyword-only argument 'a' of view 'func2' in module '__main__' must have a default

@nielsneerhoff nielsneerhoff added the fix Something isn't working label Dec 11, 2025
@nielsneerhoff nielsneerhoff enabled auto-merge (squash) December 11, 2025 17:29
@nielsneerhoff nielsneerhoff merged commit cb01b2f into main Dec 12, 2025
41 checks passed
@nielsneerhoff nielsneerhoff deleted the kwarg-only-wo-default branch December 12, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrugman sbrugman sbrugman approved these changes

Assignees

No one assigned

Labels

fix Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nielsneerhoff @sbrugman