[FIX] account_invoice_commission: adjust visibility conditions for commission pages#254
Closed
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[FIX] account_invoice_commission: adjust visibility conditions for commission pages#254rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR ajusta la visibilidad de las pestañas de comisiones en el formulario de account.move, y endurece la edición/selección de facturas relacionadas según el tipo de asiento y el estado.
Changes:
- Se ocultan las páginas “Commissions” y “Commission” también para
move_type = 'entry'. - Se añade contexto (refs de vistas) y
readonlycondicionado por estado en los one2many de comisiones. - Se incrementa la versión del módulo en el manifest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| account_invoice_commission/views/account_move_view.xml | Ajusta condiciones invisible y modifica atributos/contexto de campos de comisiones en el form de account.move. |
| account_invoice_commission/manifest.py | Bump de versión del módulo a 18.0.1.4.0. |
Comment on lines
+14
to
18
| <page string="Commissions" invisible="move_type in ('in_invoice', 'in_refund', 'in_receipt','entry')"> | ||
| <field name="commission_invoice_ids" context="{'list_view_ref':'account_invoice_commission.view_invoice_tree', 'form_view_ref':'account.move_form'}" readonly="state != 'draft'"/> | ||
| </page> | ||
| <page string="Commission" invisible="move_type in ('out_invoice', 'out_refund', 'out_receipt')"> | ||
| <page string="Commission" invisible="move_type in ('out_invoice', 'out_refund', 'out_receipt','entry')"> | ||
| <field name="commissioned_invoice_ids" context="{'commissioned_partner_id': partner_id, 'list_view_ref':'account_invoice_commission.view_invoice_tree', 'form_view_ref':'account.move_form', 'search_default_not_commissioned': True, 'search_default_closed': 1, 'search_default_invoice_user_id': partner_user_id, 'default_move_type': 'out_invoice'}" readonly="state != 'draft'"/> |
There was a problem hiding this comment.
En el context de estos campos se usa form_view_ref: 'account.move_form', pero en este módulo no existe ese XML ID (aquí se hereda account.view_move_form y el view propio es account_invoice_commission.view_move_form). Si ese form_view_ref no corresponde a un external id válido, al abrir un registro desde el one2many puede fallar. Ajustar form_view_ref a un XML ID existente (p. ej. account.view_move_form o el view heredado del módulo).
Contributor
|
@roboadhoc nobump r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Feb 20, 2026
…mmission pages closes #254 Signed-off-by: Felipe Garcia Suez <feg@adhoc.com.ar>
roboadhoc
pushed a commit
that referenced
this pull request
Feb 20, 2026
…mmission pages closes #254 Signed-off-by: Felipe Garcia Suez <feg@adhoc.com.ar>
Contributor
Author
|
@roboadhoc nobump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.