[FIX] account_background_post: avoid name collision on validate_move method#260
Closed
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[FIX] account_background_post: avoid name collision on validate_move method#260cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR evita una colisión de nombres en el wizard de validación de asientos/invoices de account_background_post, asegurando que el botón de “Confirm” no invoque accidentalmente la ruta síncrona asociada a validate_move.
Changes:
- Renombra en la vista el botón “Confirm” para que llame a
validate_move_confirmen lugar devalidate_move. - Añade un método “puente”
validate_move_confirm()en el wizard que delega envalidate_move()para conservar el comportamiento.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| account_background_post/wizards/validate_account_move_views.xml | Renombra el name del botón “Confirm” para evitar colisión con validate_move. |
| account_background_post/wizards/validate_account_move.py | Añade método validate_move_confirm() que delega en validate_move(). |
Contributor
|
@roboadhoc bump |
…method Rename the inserted Confirm button to validate_move_confirm and add a bridge method validate_move_confirm() that delegates to validate_move(). This removes the name="validate_move" collision so the background-post button cannot accidentally trigger the synchronous validate path.
cav-adhoc
force-pushed
the
18.0-h-112244-cav
branch
from
00558e4 to
bcd64f5
Compare
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Mar 11, 2026
…method Rename the inserted Confirm button to validate_move_confirm and add a bridge method validate_move_confirm() that delegates to validate_move(). This removes the name="validate_move" collision so the background-post button cannot accidentally trigger the synchronous validate path. closes #260 Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
roboadhoc
added a commit
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the inserted Confirm button to validate_move_confirm and add a bridge method validate_move_confirm() that delegates to validate_move(). This removes the name="validate_move" collision so the background-post button cannot accidentally trigger the synchronous validate path.