[IMP] account_invoice_tax: refactor tax override to use a Json field#263
Closed
fw-bot-adhoc wants to merge 1 commit intoingadhoc:19.0from
Closed
[IMP] account_invoice_tax: refactor tax override to use a Json field#263fw-bot-adhoc wants to merge 1 commit intoingadhoc:19.0from
fw-bot-adhoc wants to merge 1 commit intoingadhoc:19.0from
Conversation
Replace the old relational model approach with a lightweight
`tax_override_data = fields.Json(copy=False)` on `account.move`.
The field stores manually-set amounts keyed by tax id (string) with the
structure `{"<tax_id>": {"amount": float, "rate": float}}`.
Overrides are **only** persisted for fixed-amount taxes; percentage-based
taxes are always recomputed automatically and are never stored here.
X-original-commit: 5c86ecc
Contributor
|
|
Author
|
@maq-adhoc @rov-adhoc cherrypicking of pull request #261 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
you can use 
Author
|
@maq-adhoc @rov-adhoc this forward port of #261 is awaiting action (not merged or closed). |
1 similar comment
Author
|
@maq-adhoc @rov-adhoc this forward port of #261 is awaiting action (not merged or closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor tax override to use a Json field
Replace the old relational model approach with a lightweight
tax_override_data = fields.Json(copy=False)onaccount.move.The field stores manually-set amounts keyed by tax id (string) with the
structure
{"<tax_id>": {"amount": float, "rate": float}}.Overrides are only persisted for fixed-amount taxes; percentage-based
taxes are always recomputed automatically and are never stored here.
Forward-Port-Of: #261