[ADD] copilot instructions para GitHub PR review#5
Open
Conversation
Agrega src/.github/copilot-instructions.md.jinja y src/.github/instructions/*.instructions.md.jinja para que cada repo generado o actualizado por copier reciba las reglas de review de Copilot que mantenemos en ingadhoc/skills/copilot/. El contenido se sincroniza automáticamente desde ese repo vía el workflow sync-copilot-to-template.yml. No editar a mano acá.
El contenido no usa variables de Jinja, así que copier los copia verbatim sin necesidad del sufijo. Mantener .md simplifica el workflow de sync desde ingadhoc/skills y deja la fuente como markdown puro.
There was a problem hiding this comment.
Pull request overview
Este PR incorpora al template de repositorios Odoo las instrucciones de revisión para GitHub Copilot, con reglas globales y guías específicas por dominio (modelos, vistas, seguridad, performance, migraciones, manifest, i18n y tests) para que se propaguen a repos generados/actualizados por Copier.
Changes:
- Agrega
src/.github/copilot-instructions.md.jinjacon reglas globales y checklist de revisión. - Agrega un set de instrucciones por tipo de archivo bajo
src/.github/instructions/*.instructions.md.jinjausandoapplyTo. - Documenta criterios de revisión para Odoo (incluyendo notas específicas para Odoo 19+).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/.github/copilot-instructions.md.jinja | Define reglas globales de review y referencias cruzadas a instrucciones por dominio. |
| src/.github/instructions/views.instructions.md.jinja | Guía de review para vistas XML/QWeb (herencia, attrs, list/tree, reportes). |
| src/.github/instructions/tests.instructions.md.jinja | Criterios para sugerir/validar cobertura de tests en diffs con lógica no trivial. |
| src/.github/instructions/security.instructions.md.jinja | Checklist de seguridad (ACL, SQLi, sudo, controllers, filesystem). |
| src/.github/instructions/performance.instructions.md.jinja | Anti-patrones ORM/performance y recomendaciones para crons/compute. |
| src/.github/instructions/models.instructions.md.jinja | Guía de review para modelos (decoradores, relaciones, constraints, ORM). |
| src/.github/instructions/migrations.instructions.md.jinja | Criterios y convenciones para scripts de migración por versión. |
| src/.github/instructions/manifest.instructions.md.jinja | Checklist para __manifest__.py (data/demo/assets/depends/version). |
| src/.github/instructions/i18n.instructions.md.jinja | Reglas para i18n (_(), _lt(), placeholders y no-issues). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agrega src/.github/copilot-instructions.md.jinja y src/.github/instructions/*.instructions.md.jinja para que cada repo generado o actualizado por copier reciba las reglas de review de Copilot que mantenemos en ingadhoc/skills/copilot/.
El contenido se sincroniza automáticamente desde ese repo vía el workflow sync-copilot-to-template.yml. No editar a mano acá.