[IMP] l10n_ar_sale: calculate dates for billing in arrears#245
Closed
lav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[IMP] l10n_ar_sale: calculate dates for billing in arrears#245lav-adhoc wants to merge 1 commit intoingadhoc:18.0from
lav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
lav-adhoc
force-pushed
the
18.0-t-50515-lav
branch
3 times, most recently
from
50cba66 to
853a064
Compare
zaoral
suggested changes
Jun 24, 2025
| to_fix._compute_l10n_latam_available_document_types() | ||
| if self.is_module_installed("sale_subscription_ux"): | ||
| for invoice in invoices: | ||
| so = invoice.invoice_line_ids[0].sale_line_ids.order_id or False |
Contributor
There was a problem hiding this comment.
looks good to me! only leave a comment telling that if you try to generate an invoice from multiple sale order only will take the period of the first invoice line
In a if a future if it is needed we can change it to computhe the start/end date computing the information of all the plan period (only have sense if the period are consecutive
zaoral
suggested changes
Jun 24, 2025
| if self.is_module_installed("sale_subscription_ux"): | ||
| for invoice in invoices: | ||
| so = invoice.invoice_line_ids[0].sale_line_ids.order_id or False | ||
| if so and so.plan_id.bill_end_period: |
Contributor
There was a problem hiding this comment.
Runbot returns this error:
AttributeError: 'sale.subscription.plan' object has no attribute 'bill_end_period'. Did you mean: 'billing_period'?
lav-adhoc
force-pushed
the
18.0-t-50515-lav
branch
from
853a064 to
60fc0b6
Compare
lav-adhoc
force-pushed
the
18.0-t-50515-lav
branch
3 times, most recently
from
9a54633 to
490807d
Compare
lav-adhoc
force-pushed
the
18.0-t-50515-lav
branch
from
490807d to
fbe86c3
Compare
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Jun 26, 2025
closes #245 Signed-off-by: matiasperalta1 <mnp@adhoc.com.ar>
roboadhoc
pushed a commit
that referenced
this pull request
Jun 26, 2025
closes #245 Signed-off-by: matiasperalta1 <mnp@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.