Skip to content

[FIX] l10n_ar_sale: duplicado de órdenes de venta, cómputo de impuestos #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjscarafia merged 1 commit into from
Mar 3, 2026
Merged

[FIX] l10n_ar_sale: duplicado de órdenes de venta, cómputo de impuestos #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion l10n_ar_sale/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Argentinian Sale Total Fields",
"version": "19.0.1.2.0",
"version": "19.0.1.3.0",
"category": "Localization/Argentina",
"sequence": 14,
"author": "ADHOC SA",
Expand Down
21 changes: 12 additions & 9 deletions l10n_ar_sale/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,20 @@ def is_module_installed(self, module):
)
return True if module_installed else False

@api.onchange("date_order")
@api.onchange("date_order", "commercial_partner_id")
def _l10n_ar_recompute_fiscal_position_taxes(self):
"""Recalculamos las percepciones si cambiamos la fecha de la orden de venta. Para ello nos basamos en los
impuestos de la posicion fiscal, buscamos si hay impuestos existentes para los tax groups involucrados y los
reemplazamos por los nuevos impuestos.
"""Recalculamos las percepciones si cambiamos la fecha de la orden de venta o el commercial partner.
Para ello nos basamos en los impuestos de la posicion fiscal, buscamos si hay impuestos existentes para los tax groups involucrados y los
reemplazamos por los nuevos impuestos.
NO lo hacemos para el cambio de fiscal_position_id porque el onchange de fiscal_position_id implementado en sale_ux ya recomputa todos los taxes
NOTA: en facturas no tenemos approach exactamente igual ya que en facturas es opcional el auto update a través del módulo
account_invoice_fiscal_position_update
"""
for rec in self.filtered(
lambda x: x.fiscal_position_id.l10n_ar_tax_ids.filtered(lambda x: x.tax_type == "perception")
and x.state not in ["cancel", "sale"]
lambda x: (
x.fiscal_position_id.l10n_ar_tax_ids.filtered(lambda x: x.tax_type == "perception")
and x.state not in ["cancel", "sale"]
)
):
fp_tax_groups = rec.fiscal_position_id.l10n_ar_tax_ids.filtered(
lambda x: x.tax_type == "perception"
Expand All @@ -112,9 +117,7 @@ def _l10n_ar_recompute_fiscal_position_taxes(self):
for line in rec.order_line:
to_unlink = line.tax_ids.filtered(lambda x: x.tax_group_id in fp_tax_groups)
if to_unlink._origin != new_taxes:
line.tax_ids = [(3, tax.id) for tax in to_unlink] + [
(4, tax.id) for tax in new_taxes if tax not in line.tax_ids
]
line.tax_id = (line.tax_id - to_unlink) | new_taxes

def copy(self, default=None):
"""Re computamos las percepciones al duplicar una venta porque puede ser que la orden venga de otro periodo
Expand Down