[IMP] account_statement_import_sheet_file_bg: Filter empty rows by date column#354
Closed
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[IMP] account_statement_import_sheet_file_bg: Filter empty rows by date column#354rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR mejora el rendimiento del módulo account_statement_import_sheet_file_bg al filtrar filas vacías en archivos Excel basándose en la columna de fecha/timestamp. Anteriormente, se procesaban todas las filas del archivo, incluyendo miles de filas vacías al final, causando problemas de rendimiento.
Changes:
- Se agregó filtrado de filas por columna de fecha en el método
split_base64_excel - Se implementaron dos nuevos métodos auxiliares:
_get_date_column_indexy_filter_rows_with_date - El procesamiento ahora se detiene al encontrar la primera fila con timestamp vacío
rov-adhoc
commented
Jan 23, 2026
| start_row_index = end_row_index | ||
| return output_base64_list | ||
|
|
||
| def _get_date_column_index(self, header_rows): |
Contributor
Author
There was a problem hiding this comment.
pasar a pase header
rov-adhoc
force-pushed
the
18.0-h-108505-rov
branch
from
b5b9807 to
c95035d
Compare
…te column Stop processing Excel rows when timestamp column is empty Previously, the import would process all rows in the Excel file until the end, including thousands of empty rows. This caused performance issues and unnecessary data processing. Now the system: - Identifies the date/timestamp column from sheet_mapping_id configuration - Only processes rows where the timestamp column has a value - Stops processing at the first empty timestamp row This prevents importing empty rows and improves performance when handling Excel files with many empty rows at the end.
rov-adhoc
force-pushed
the
18.0-h-108505-rov
branch
from
c95035d to
cafc77d
Compare
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Jan 23, 2026
…te column Stop processing Excel rows when timestamp column is empty Previously, the import would process all rows in the Excel file until the end, including thousands of empty rows. This caused performance issues and unnecessary data processing. Now the system: - Identifies the date/timestamp column from sheet_mapping_id configuration - Only processes rows where the timestamp column has a value - Stops processing at the first empty timestamp row This prevents importing empty rows and improves performance when handling Excel files with many empty rows at the end. closes #354 Signed-off-by: Filoquin adhoc <maq@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop processing Excel rows when timestamp column is empty
Previously, the import would process all rows in the Excel file until the end, including thousands of empty rows. This caused performance issues and unnecessary data processing.
Now the system:
This prevents importing empty rows and improves performance when handling Excel files with many empty rows at the end.