[IMP] l10n_ar_tax: add monthly cron to clean old padron files#1375
Closed
pablohmontenegro wants to merge 1 commit intoingadhoc:18.0from
Closed
[IMP] l10n_ar_tax: add monthly cron to clean old padron files#1375pablohmontenegro wants to merge 1 commit intoingadhoc:18.0from
pablohmontenegro wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR incorpora un mantenimiento automático en l10n_ar_tax para eliminar registros de padrón antiguos (ARBA / Santa Fe) y así reducir el uso de almacenamiento del módulo.
Changes:
- Se agrega el método
_cron_clean_old_padron_files()en el modelores.company.jurisdiction.padronpara borrar padrones con vigencia anterior a ~1 año. - Se crea un
ir.cronmensual (en data connoupdate="1") para ejecutar la limpieza automáticamente. - Se referencia el nuevo XML de cron en el
__manifest__.py.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
l10n_ar_tax/models/res_company_jurisdiction_padron.py |
Implementa la lógica de limpieza por fecha y hace el unlink() de registros antiguos. |
l10n_ar_tax/data/ir_cron_data.xml |
Define el cron mensual que ejecuta el método de limpieza. |
l10n_ar_tax/__manifest__.py |
Incluye el nuevo archivo de datos del cron en la carga del módulo. |
pablohmontenegro
force-pushed
the
18.0-t-65316-pam
branch
2 times, most recently
from
0557fa4 to
cfee88c
Compare
zaoral
reviewed
Apr 22, 2026
Contributor
zaoral
left a comment
zaoral
left a comment
There was a problem hiding this comment.
Thank you for the PR @pablohmontenegro
I leave you some comments to check
pablohmontenegro
force-pushed
the
18.0-t-65316-pam
branch
2 times, most recently
from
98b3ca6 to
356487b
Compare
1) Add _cron_clean_old_padron_files method to delete old records. 2) Create cron in data (noupdate="1") with monthly execution. 3) Add test_cron_deletes_only_old_padrons test ( odoo-argentina/l10n_ar_tax/tests/test_padron_cleanup_cron.py ) to verify old records are deleted after cron execution. Task Adhoc side: 65316
pablohmontenegro
force-pushed
the
18.0-t-65316-pam
branch
from
356487b to
eae74c9
Compare
zaoral
approved these changes
Apr 23, 2026
Contributor
zaoral
left a comment
zaoral
left a comment
There was a problem hiding this comment.
@pablohmontenegro
Thank you for the PR and the changes!
@roboadhoc bump r+
roboadhoc
pushed a commit
that referenced
this pull request
Apr 23, 2026
1) Add _cron_clean_old_padron_files method to delete old records. 2) Create cron in data (noupdate="1") with monthly execution. 3) Add test_cron_deletes_only_old_padrons test ( odoo-argentina/l10n_ar_tax/tests/test_padron_cleanup_cron.py ) to verify old records are deleted after cron execution. Task Adhoc side: 65316 closes #1375 Signed-off-by: Katherine Zaoral - kz (#l10n) <kz@adhoc.com.ar>
roboadhoc
added a commit
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Adhoc side: 65316