Security: Arbitrary Python Code Execution via python_formula#1402
Open
tomaioo wants to merge 1 commit into
Open
Security: Arbitrary Python Code Execution via python_formula#1402tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
The code in account_fiscal_position_l10n_ar_tax.py uses safe_eval to execute arbitrary Python code from the python_formula field. This allows any user with access to configure fiscal positions to execute arbitrary Python code on the server, leading to full system compromise. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Arbitrary Python Code Execution via python_formula
Problem
Severity:
Critical| File:l10n_ar_tax_python/models/account_fiscal_position_l10n_ar_tax.py:L47The code in account_fiscal_position_l10n_ar_tax.py uses safe_eval to execute arbitrary Python code from the python_formula field. This allows any user with access to configure fiscal positions to execute arbitrary Python code on the server, leading to full system compromise.
Solution
Replace safe_eval with a restricted expression evaluator or remove this feature entirely. If Python formulas are required, implement a sandboxed environment with limited built-in functions and no access to file system, network, or Odoo internals.
Changes
l10n_ar_tax_python/models/account_fiscal_position_l10n_ar_tax.py(modified)