[FIX] _cost_sale_margin:: do not recompute on rep cost change#847
Closed
jjscarafia wants to merge 1 commit intoingadhoc:18.0from
Closed
[FIX] _cost_sale_margin:: do not recompute on rep cost change#847jjscarafia wants to merge 1 commit intoingadhoc:18.0from
jjscarafia wants to merge 1 commit intoingadhoc:18.0from
Conversation
el depnds este era terrible a nivel performance (traslada todos los depends de rep cost) y además funcionalmente no es deseado, cambios en costo (por cualquier motivo), no deberían recomputar los costos existentes X-original-commit: a2442ca
Contributor
|
|
Member
Author
|
@roboadhoc r+ |
There was a problem hiding this comment.
Pull request overview
Este PR elimina el decorador @api.depends("product_id.replenishment_cost") del método _compute_purchase_price en las líneas de venta. Según la descripción, este depends causaba problemas de rendimiento al trasladar todas las dependencias del campo replenishment_cost y, funcionalmente, no es deseable que cambios en el costo recomputen automáticamente los costos existentes en órdenes de venta ya creadas.
Changes:
- Se elimina el decorador
@api.depends("product_id.replenishment_cost")del método_compute_purchase_price - Se elimina la importación de
apideodooya que no se usa más en el archivo
roboadhoc
pushed a commit
that referenced
this pull request
Jan 13, 2026
el depnds este era terrible a nivel performance (traslada todos los depends de rep cost) y además funcionalmente no es deseado, cambios en costo (por cualquier motivo), no deberían recomputar los costos existentes closes #847 X-original-commit: a2442ca Signed-off-by: Juan José Scarafía <jjs@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
el depnds este era terrible a nivel performance (traslada todos los depends de rep cost) y además funcionalmente no es deseado, cambios en costo (por cualquier motivo), no deberían recomputar los costos existentes
X-original-commit: a2442ca
FP de esto #835