[FIX] sale_order_type_automation: check type_id is set before checking invoicing automation#1641
Open
gal-adhoc wants to merge 1 commit intoingadhoc:18.0from
Open
[FIX] sale_order_type_automation: check type_id is set before checking invoicing automation#1641gal-adhoc wants to merge 1 commit intoingadhoc:18.0from
gal-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
…g invoicing automation
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Without this check, a sale order with no type_id would pass the filter in
run_invoicing_atomationbecause accessinginvoicing_atomationon an empty Many2one returnsFalse, andFalse != "none"evaluates toTrue, causing the order to be auto-invoiced unintentionally.Related
Helpdesk ticket: #115934
Branch:
18.0-h-115934-gal