Skip to content

[FIX] l10n_uy_ux: avoid running vendor bills cron on testing mode#402

Closed
jue-adhoc wants to merge 2 commits intoingadhoc:18.0from
adhoc-dev:18.0-t-65165-jue
Closed

[FIX] l10n_uy_ux: avoid running vendor bills cron on testing mode#402
jue-adhoc wants to merge 2 commits intoingadhoc:18.0from
adhoc-dev:18.0-t-65165-jue

Conversation

@jue-adhoc
Copy link
Copy Markdown
Contributor

@jue-adhoc jue-adhoc commented Mar 12, 2026

En este PR agregamos 2 cambios para evitar warnings en las builds de runbot:
1- Agregamos un chequeo para evitar que el cron que obtiene las facturas de proveedor de UY se ejecute en modo demo, lo que ayuda a evitar errores debidos a la falta de datos de producción.
2- Corregimos el dominio del search que utilizamos para correr el cron de actualización de estado de DGI.

Control de la ejecución de tareas cron:

  • Se ha añadido una comprobación utilizando get_mode() en cron_l10n_uy_edi_get_vendor_bills para evitar que el cron se ejecute en modo demo, evitando así errores causados por la falta de datos de producción. (l10n_uy_ux/models/l10n_uy_edi_document.py) [[1]](https://github.com/ingadhoc/uruguay/pull/402/files# diff-b0640919b30e9cc362e4696f59d62953f5da612adb96c9e6601334fad607a2dbR2) [[2]](https://github.com/ingadhoc/uruguay/pull/402/files# diff-b0640919b30e9cc362e4696f59d62953f5da612adb96c9e6601334fad607a2dbR159-R164)
    Sí dejamos que se corra para los tests, por eso agregamos la siguiente condición a la sentencia if: if not tools.config.get("test_enable")

Actualización del estado de selección de acciones DGI:

  • Se ha modificado el dominio en _l10n_uy_edi_stock_cron_update_dgi_status para eliminar el requisito de que l10n_uy_is_cfe sea True, por lo que ahora se actualizan todas las selecciones en estado «recibido» independientemente de este indicador. (l10n_uy_edi_stock/models/stock_picking.py)

Copilot AI review requested due to automatic review settings March 12, 2026 16:14
@roboadhoc
Copy link
Copy Markdown
Contributor

Pull request status dashboard

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR busca evitar que el cron que descarga/actualiza facturas de proveedor (vendor bills) se ejecute en entornos de testing/demo, ya que en esos entornos puede fallar por falta de datos/configuración productiva.

Changes:

  • Se importa get_mode desde server_mode para detectar el “modo” del servidor.
  • Se sobreescribe cron_l10n_uy_edi_get_vendor_bills() para salir temprano y no ejecutar la lógica del cron en ciertos modos.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread l10n_uy_ux/models/l10n_uy_edi_document.py
Comment thread l10n_uy_ux/models/l10n_uy_edi_document.py Outdated
@jue-adhoc jue-adhoc force-pushed the 18.0-t-65165-jue branch 2 times, most recently from 4e79d1b to 5e1cb84 Compare April 14, 2026 17:35
Copy link
Copy Markdown
Contributor

@zaoral zaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jue-adhoc !
@roboadhoc nobump r+

@roboadhoc
Copy link
Copy Markdown
Contributor

@zaoral you may want to rebuild or fix this PR as it has failed CI.

@roboadhoc
Copy link
Copy Markdown
Contributor

@jue-adhoc @zaoral because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@zaoral
Copy link
Copy Markdown
Contributor

zaoral commented Apr 14, 2026

@roboadhoc rebase-ff
@roboadhoc override=ci/runbot-oba
We force due to an external error :

Error found in logs:
2026-04-14 13:42:32,142 9 ERROR 64088-18-0-all odoo.addons.hr_attendance.tests.test_hr_attendance_overtime: FAIL: TestHrAttendanceOvertime.test_absence_management
2026-04-14 13:44:47,086 9 ERROR 64088-18-0-all odoo.tests.result: 1 failed, 0 error(s) of 379 tests when loading database '64088-18-0-all'

more info in https://runbot.dev-adhoc.com/runbot/batch/43778/build/64088

roboadhoc pushed a commit that referenced this pull request Apr 14, 2026
Part-of: #402
Signed-off-by: Katherine Zaoral - kz (#l10n) <kz@adhoc.com.ar>
roboadhoc pushed a commit that referenced this pull request Apr 14, 2026
closes #402

Signed-off-by: Katherine Zaoral - kz (#l10n) <kz@adhoc.com.ar>
@roboadhoc
Copy link
Copy Markdown
Contributor

Merge method set to rebase and fast-forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants